Adjust per pool by number of pools#1521
Open
erthalion wants to merge 2 commits into
Open
Conversation
default_pool_size, min_pool_size, reserve_pool_size are per pool values, that's it per (database, user) pair. Which means it's wrong to calculate them based on the global maxDBConn, otherwise for the cases when there are too many users it would result in the configuration conflicting between maxDBConn and min_pool_size. Adjust those values by the number of known pools. This not necessarily a perfect solution, because load could be distributed between databases & users unevenly in which case some of those parameters will cause rarely used pools being of the same size as the active ones.
erthalion
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
Contributor
|
unit test fail: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_pool_size, min_pool_size, reserve_pool_size are per pool values,
that's it per (database, user) pair. Which means it's wrong to calculate
them based on the global maxDBConn, otherwise for the cases when there
are too many users it would result in the configuration conflicting
between maxDBConn and min_pool_size. Adjust those values by the number
of known pools.
This not necessarily a perfect solution, because load could be
distributed between databases & users unevenly in which case some of
those parameters will cause rarely used pools being of the same size as
the active ones.